risdenk commented on a change in pull request #178: KNOX-2071 - Configurable maximum token lifetime for TokenStateService URL: https://github.com/apache/knox/pull/178#discussion_r343186849
########## File path: gateway-service-knoxtoken/src/test/java/org/apache/knox/gateway/service/knoxtoken/TokenServiceResourceTest.java ########## @@ -23,6 +23,7 @@ import com.nimbusds.jose.JWSVerifier; import com.nimbusds.jose.crypto.RSASSASigner; import com.nimbusds.jose.crypto.RSASSAVerifier; +import org.apache.commons.lang3.tuple.Pair; Review comment: Right but would be better to get rid of it in other modules instead of just using that as an argument to keep adding it. Once it is added as a test module that opens it up to other usages. The only way to prevent usage is to make sure its not included in the pom. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
