[
https://issues.apache.org/jira/browse/KNOX-2126?focusedWorklogId=344550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344550
]
ASF GitHub Bot logged work on KNOX-2126:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/19 20:28
Start Date: 15/Nov/19 20:28
Worklog Time Spent: 10m
Work Description: pzampino commented on pull request #195: KNOX-2126. Add
an API to retrieve the public key used for Knox JWT verification.
URL: https://github.com/apache/knox/pull/195#discussion_r346998074
##########
File path:
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
##########
@@ -278,6 +284,39 @@ public Response revoke(String token) {
return resp;
}
+ @GET
+ @Path(PUBLIC_KEY_PATH)
+ @Produces ({APPLICATION_JSON})
+ public Response publicKey() {
+ GatewayServices services = (GatewayServices) request.getServletContext()
+ .getAttribute(GatewayServices.GATEWAY_SERVICES_ATTRIBUTE);
+
+ KeystoreService ks = services.getService(ServiceType.KEYSTORE_SERVICE);
+
+ try {
+ PublicKey publicKey =
ks.getSigningKeystore().getCertificate(getSigningKeyAlias()).getPublicKey();
+ publicKey.getAlgorithm();
+ byte[] pubKeyBytes = publicKey.getEncoded();
+ String base64Key = Base64.encodeBase64String(pubKeyBytes);
+ Map<String, String> map = new HashMap<>();
+ map.put(PUBLIC_KEY, base64Key);
+ map.put(ALGORITHM, publicKey.getAlgorithm());
+
+ String jsonResponse = JsonUtils.renderAsJsonString(map);
+ return Response.ok().entity(jsonResponse).build();
+ } catch (KeyStoreException | KeystoreServiceException e) {
+ return Response.serverError().build();
Review comment:
We should at least log the exception message here in the gateway log.
I'm always conflicted about how much detail we should return to the client
in such cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 344550)
Time Spent: 40m (was: 0.5h)
> Add an API to retrieve the public key used for Knox JWT verification
> --------------------------------------------------------------------
>
> Key: KNOX-2126
> URL: https://issues.apache.org/jira/browse/KNOX-2126
> Project: Apache Knox
> Issue Type: New Feature
> Reporter: Siddharth Seth
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It can be useful to get access to the PublicKey used by Knox to verify the
> tokens that it generates outside of Knox.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
