[ 
https://issues.apache.org/jira/browse/KNOX-2126?focusedWorklogId=344587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344587
 ]

ASF GitHub Bot logged work on KNOX-2126:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Nov/19 21:11
            Start Date: 15/Nov/19 21:11
    Worklog Time Spent: 10m 
      Work Description: sidseth commented on pull request #195: KNOX-2126. Add 
an API to retrieve the public key used for Knox JWT verification.
URL: https://github.com/apache/knox/pull/195#discussion_r347012552
 
 

 ##########
 File path: 
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
 ##########
 @@ -278,6 +284,39 @@ public Response revoke(String token) {
     return resp;
   }
 
+  @GET
+  @Path(PUBLIC_KEY_PATH)
+  @Produces ({APPLICATION_JSON})
+  public Response publicKey() {
+    GatewayServices services = (GatewayServices) request.getServletContext()
+        .getAttribute(GatewayServices.GATEWAY_SERVICES_ATTRIBUTE);
+
+    KeystoreService ks = services.getService(ServiceType.KEYSTORE_SERVICE);
+
+    try {
+      PublicKey publicKey = 
ks.getSigningKeystore().getCertificate(getSigningKeyAlias()).getPublicKey();
+      publicKey.getAlgorithm();
+      byte[] pubKeyBytes = publicKey.getEncoded();
+      String base64Key = Base64.encodeBase64String(pubKeyBytes);
 
 Review comment:
   @risdenk - could you please elaborate a bit. Are you also suggesting 
including this information in the response (i.e. will the client need this to 
interpret the response correctly - that is why I had initially included the 
algorithm. I'd imagine the format is actually more important).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 344587)
    Time Spent: 2h 10m  (was: 2h)

> Add an API to retrieve the public key used for Knox JWT verification
> --------------------------------------------------------------------
>
>                 Key: KNOX-2126
>                 URL: https://issues.apache.org/jira/browse/KNOX-2126
>             Project: Apache Knox
>          Issue Type: New Feature
>            Reporter: Siddharth Seth
>            Priority: Major
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> It can be useful to get access to the PublicKey used by Knox to verify the 
> tokens that it generates outside of Knox.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to