[
https://issues.apache.org/jira/browse/KNOX-1921?focusedWorklogId=360596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-360596
]
ASF GitHub Bot logged work on KNOX-1921:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Dec/19 23:58
Start Date: 16/Dec/19 23:58
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #221: KNOX-1921 - CM
discovery - Hue Load balancer HTTP/HTTPS scheme
URL: https://github.com/apache/knox/pull/221#discussion_r358528667
##########
File path:
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/collector/HueURLCollector.java
##########
@@ -28,12 +28,27 @@
*/
public class HueURLCollector extends AbstractURLCollector {
+ private static final String SCHEME_HTTP = "http";
+ private static final String SCHEME_HTTPS = "https";
Review comment:
Might make sense to put on abstract url collector since will be used a bunch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 360596)
Time Spent: 20m (was: 10m)
> CM discovery - Hue Load balancer HTTP/HTTPS scheme
> --------------------------------------------------
>
> Key: KNOX-1921
> URL: https://issues.apache.org/jira/browse/KNOX-1921
> Project: Apache Knox
> Issue Type: Sub-task
> Components: cm-discovery
> Affects Versions: 1.3.0
> Reporter: Jean-Francois Desjeans Gauthier
> Assignee: Philip Zampino
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> With KNOX-1875, the Hue scheme is determined dynamically, but the Hue load
> balancer scheme is not. Is it possible to enable the same dynamic scheme
> determination for the load balancer?
> [https://gitbox.apache.org/repos/asf?p=knox.git;a=blob;f=gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/model/hue/HueLBServiceModelGenerator.java;h=63eb0b690c9635230285bb84a7c939b0f4cfcf44;hb=248f08c#l45]
> [https://gitbox.apache.org/repos/asf?p=knox.git;a=blob;f=gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/model/hue/HueServiceModelGenerator.java;h=12e4eb314d730193430745b480bcf77081375a59;hb=248f08c#l48]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
