risdenk commented on issue #230: KNOX-2157 - Verifying the server's state in 
addition to PID check at gateway start
URL: https://github.com/apache/knox/pull/230#issuecomment-570297655
 
 
   So just to make sure I understand the problem, the issue is that the 
launcher runs the gateway process and doesn't wait for the initialization of 
the server to complete before returning and saying this is up and running.
   
   Is it possible to maybe use the listener or another method in the 
GatewayServer to wait until initialization is complete? Is the launcher 
returning too soon? 
   
   Ideally after `GatewayServer` starts the server would be completely ready. 
It is weird that we are saying that everything is good before that :/
   
   I am not sure I am a fan of the writing a file and checking the output to 
avoid what looks to be a fundamental gateway starting issue. I wonder how we 
avoid this in tests currently. There must be an existing method to make sure 
that the topology is deployed or something along those lines or we would see 
issues like this in the tests. The solution in this PR wouldn't help the tests 
since it would be in the shell script only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to