smolnar82 commented on a change in pull request #230: KNOX-2157 - Verifying the
server's state in addition to PID check at gateway start
URL: https://github.com/apache/knox/pull/230#discussion_r363465413
##########
File path: gateway-release-common/home/bin/knox-functions.sh
##########
@@ -250,6 +302,11 @@ function appStop {
exit 1
else
rm -f "$APP_PID_FILE"
+
+ #TODO: due to the current way of shutting down the server the status has
never been changed to STOPPED (STARTING seems to be not reliable either which
is weird).
Review comment:
Currently, the JVM is "stopped" with a `kill` command but there is no
[shutdown
hook](https://docs.oracle.com/javase/8/docs/api/java/lang/Runtime.html#addShutdownHook-java.lang.Thread-)
registered in `GatewayServer`. Adding a shutdown hook would help in most of
the cases but it may still send a SIGKILL when stopping a server 'normally' did
not succeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
