pzampino commented on a change in pull request #233: KNOX-2160 - Monitoring and processing refreshable service parameters URL: https://github.com/apache/knox/pull/233#discussion_r364821819
########## File path: gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java ########## @@ -233,6 +233,12 @@ static final String REMOTE_ALIAS_SERVICE_CONFIG_PREFIX = GATEWAY_CONFIG_FILE_PREFIX + ".remote.alias.service.config.prefix"; static final String REMOTE_ALIAS_SERVICE_CONFIG_PREFIX_DEFAULT = GATEWAY_CONFIG_FILE_PREFIX + ".remote.alias.service.config."; + public static final String REFRESHABLE_SERVIVCE_PARAMETERS_FILENAME = "refreshable-service-parameters.xml"; Review comment: Since service params are already refreshable via direct descriptor editing, I don't think that needs to be emphasized in the naming herein. This feature is really about updating granular parts of descriptors, and the naming should reflect that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
