pzampino commented on a change in pull request #233: KNOX-2160 - Monitoring and 
processing refreshable service parameters
URL: https://github.com/apache/knox/pull/233#discussion_r364849353
 
 

 ##########
 File path: 
gateway-server/src/main/java/org/apache/knox/gateway/descriptor/RefreshableServiceParametersConfiguration.java
 ##########
 @@ -46,23 +49,24 @@ public RefreshableServiceParametersConfiguration(Path 
resourcePath) throws Malfo
   }
 
   // the configuration value equals to BLOCK_1;BLOCK_2;...BLOCK_N,
-  // where BLOCK_* is built up as 
$TOPOLOGY.$SERVICE.$PARMAPETER_NAME=$PARAMETER_VALUE
+  // where BLOCK_* is built up as 
$TOPOLOGY:$SERVICE:$VERSION:$PARMAPETER_NAME=$PARAMETER_VALUE
 
 Review comment:
   nit: **$PARAMAPETER_NAME**

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to