pzampino commented on a change in pull request #236: KNOX-2160 - Introducing 
Hadoop XML type descriptor format
URL: https://github.com/apache/knox/pull/236#discussion_r366518075
 
 

 ##########
 File path: 
gateway-server/src/main/java/org/apache/knox/gateway/services/topology/impl/DefaultTopologyService.java
 ##########
 @@ -901,8 +906,8 @@ public void onFileChange(File file) {
     public boolean accept(File file) {
       boolean accept = false;
       if (!file.isDirectory() && file.canRead()) {
-        String extension = FilenameUtils.getExtension(file.getName());
-        if (SUPPORTED_EXTENSIONS.contains(extension)) {
+        String fileName = file.getName();
+        if (isDescriptorFile(fileName) || isXmlTypeDescriptorFile(fileName)) {
 
 Review comment:
   I thought there was going to be a separate monitor for this CM integration 
descriptor, the handling of which would be contained in the cm-integration 
module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to