smolnar82 commented on a change in pull request #236: KNOX-2160 - Introducing 
Hadoop XML type descriptor format
URL: https://github.com/apache/knox/pull/236#discussion_r366723388
 
 

 ##########
 File path: 
gateway-server/src/main/java/org/apache/knox/gateway/services/topology/impl/DefaultTopologyService.java
 ##########
 @@ -901,8 +906,8 @@ public void onFileChange(File file) {
     public boolean accept(File file) {
       boolean accept = false;
       if (!file.isDirectory() && file.canRead()) {
-        String extension = FilenameUtils.getExtension(file.getName());
-        if (SUPPORTED_EXTENSIONS.contains(extension)) {
+        String fileName = file.getName();
+        if (isDescriptorFile(fileName) || isXmlTypeDescriptorFile(fileName)) {
 
 Review comment:
   I think we agreed to use the existing monitor. On the other hand, it's 
better separated if monitoring was in the new cm-integration module. Let me do 
it there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to