[
https://issues.apache.org/jira/browse/KNOX-2153?focusedWorklogId=374866&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-374866
]
ASF GitHub Bot logged work on KNOX-2153:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/20 09:21
Start Date: 21/Jan/20 09:21
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #239: KNOX-2153 -
CM discovery - Monitor Cloudera Manager
URL: https://github.com/apache/knox/pull/239#discussion_r368886079
##########
File path:
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/model/oozie/OozieServiceModelGenerator.java
##########
@@ -59,15 +63,22 @@ public ServiceModel generateService(ApiService
service,
String hostname = role.getHostRef().getHostname();
String scheme;
String port;
- boolean sslEnabled =
Boolean.parseBoolean(getServiceConfigValue(serviceConfig, "oozie_use_ssl"));
- if(sslEnabled) {
+ String sslEnabled = getServiceConfigValue(serviceConfig, USE_SSL);
+ if(Boolean.parseBoolean(sslEnabled)) {
scheme = "https";
- port = getRoleConfigValue(roleConfig, "oozie_https_port");
+ port = getRoleConfigValue(roleConfig, HTTPS_PORT);
} else {
scheme = "http";
- port = getRoleConfigValue(roleConfig, "oozie_http_port");
+ port = getRoleConfigValue(roleConfig, HTTP_PORT);
}
Review comment:
This is a recurring code in many of the different service implementation.
You may consider implementing a method in `AbstractServiceModelGenerator` which
returns the correct scheme and the port.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 374866)
Time Spent: 2h 10m (was: 2h)
> CM discovery - Monitor Cloudera Manager
> ---------------------------------------
>
> Key: KNOX-2153
> URL: https://issues.apache.org/jira/browse/KNOX-2153
> Project: Apache Knox
> Issue Type: Sub-task
> Components: cm-discovery
> Affects Versions: 1.4.0
> Reporter: Sandor Molnar
> Assignee: Philip Zampino
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Knox needs to have monitoring capabilities implemented for Cloudera Manager
> service-discovery the same way as supported for Ambari (see KNOX-1013).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
