pzampino commented on a change in pull request #257: KNOX-2214 - Periodic job
to evict expired tokens
URL: https://github.com/apache/knox/pull/257#discussion_r377729105
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
##########
@@ -264,4 +280,29 @@ protected String getTokenDisplayText(final String token) {
return String.format(Locale.ROOT, "%s...%s", token.substring(0, 10),
token.substring(token.length() - 3));
}
+ /**
+ * Method that deletes expired tokens based on the token timestamp.
+ */
+ protected void evictExpiredTokens() {
+ try {
+ for (final String token : getTokens()) {
+ if (isExpired(token)) {
Review comment:
Yes, as we've discussed, while renewers likely will request renewals prior
to expiration, they are not currently required to do so. Delaying the eviction
avoids potential "unknown token" issues for renewers, and does not affect the
expiration time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services