pzampino commented on a change in pull request #257: KNOX-2214 - Periodic job 
to evict expired tokens
URL: https://github.com/apache/knox/pull/257#discussion_r377890400
 
 

 ##########
 File path: 
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
 ##########
 @@ -51,13 +51,16 @@
 
   /* token eviction interval in seconds, default is 5 mins */
   private long tokenEvictionInterval;
+  /* grace period (in seconds) after which an expired token should be evicted, 
default 5 mins */
 
 Review comment:
   nit: This comment won't change when the default value changes in the future. 
I try not to include values in comments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to