[GitHub] [knox] smolnar82 commented on issue #263: KNOX-2226 - Add home page to Knox

[GitBox]

smolnar82 commented on issue #263: KNOX-2226 - Add home page to Knox
URL: https://github.com/apache/knox/pull/263#issuecomment-586152593
 
 
   @risdenk ,
   
   WRT your JSON question: on one hand, you are right, it'd be cleaner when 
reading the JSON as you recommended. On the other hand, this API generates XML 
output too, and in that case, the current structure is cleaner IMO:
   ```
         <uiServices>
            <service>
               <context>/druid-coordinator-ui/</context>
               <description>The Druid Coordinator exposes a web GUI for 
displaying cluster information and rule configuration.</description>
               <serviceName>DRUID-COORDINATOR-UI</serviceName>
               
<serviceUrl>https://localhost:8443/gateway/sandbox/druid-coordinator-ui/</serviceUrl>
               <shortDesc>Druid Coordinator Console</shortDesc>
               <type>UI</type>
            </service>
            <service>
               <context>/druid-overlord-ui/</context>
               <description>The Overlord provides a UI for managing tasks and 
workers.</description>
               <serviceName>DRUID-OVERLORD-UI</serviceName>
               
<serviceUrl>https://localhost:8443/gateway/sandbox/druid-overlord-ui/</serviceUrl>
               <shortDesc>Druid Overlord Console</shortDesc>
               <type>UI</type>
            </service>
            <service>
               <context>/hue/</context>
               <description>Hue UI is a Web interface for analyzing data with 
Apache Hadoop</description>
               <serviceName>HUE</serviceName>
               
<serviceUrl>https://localhost:8443/gateway/sandbox/hue/</serviceUrl>
               <shortDesc>Hue UI</shortDesc>
               <type>UI</type>
            </service>
         </uiServices>
   ```
   
   Moreover, the current solution is consistent with Admin API outputs:
   ```
   $ curl -iku admin:admin-password -H "Accept: application/json" 
'https://localhost:8443/gateway/admin/api/v1/topologies/'
   HTTP/1.1 200 OK
   Date: Fri, 14 Feb 2020 08:26:44 GMT
   Set-Cookie: KNOXSESSIONID=node01wffn263vit5nemdc9021f45z3.node0; 
Path=/gateway/admin; Secure; HttpOnly
   Expires: Thu, 01 Jan 1970 00:00:00 GMT
   Set-Cookie: rememberMe=deleteMe; Path=/gateway/admin; Max-Age=0; 
Expires=Thu, 13-Feb-2020 08:26:44 GMT
   Content-Type: application/json
   Content-Length: 1160
   Server: Jetty(9.4.26.v20200117)
   
   {
      "topologies" : {
         "topology" : [ {
            "name" : "admin",
            "timestamp" : "1581667994000",
            "uri" : "https://localhost:8443/gateway/admin";,
            "href" : 
"https://localhost:8443/gateway/admin/api/v1/topologies/admin";
         }, {
            "name" : "cdp-proxy",
            "timestamp" : "1581625805000",
            "uri" : "https://localhost:8443/gateway/cdp-proxy";,
            "href" : 
"https://localhost:8443/gateway/admin/api/v1/topologies/cdp-proxy";
         }, {
            "name" : "knoxsso",
            "timestamp" : "1581625577000",
            "uri" : "https://localhost:8443/gateway/knoxsso";,
            "href" : 
"https://localhost:8443/gateway/admin/api/v1/topologies/knoxsso";
         }, {
            "name" : "manager",
            "timestamp" : "1581667994000",
            "uri" : "https://localhost:8443/gateway/manager";,
            "href" : 
"https://localhost:8443/gateway/admin/api/v1/topologies/manager";
         }, {
            "name" : "sandbox",
            "timestamp" : "1581625577000",
            "uri" : "https://localhost:8443/gateway/sandbox";,
            "href" : 
"https://localhost:8443/gateway/admin/api/v1/topologies/sandbox";
         } ]
      }
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services