risdenk commented on a change in pull request #263: KNOX-2226 - Add home page 
to Knox
URL: https://github.com/apache/knox/pull/263#discussion_r383917425
 
 

 ##########
 File path: gateway-release/home/conf/topologies/metadata.xml
 ##########
 @@ -0,0 +1,64 @@
+<?xml version="1.0" encoding="utf-8"?>
 
 Review comment:
   Is this topology just an example? Does it need to be exposed by default? If 
its an example `gateway-release/home/templates/` would be a better place.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to