[
https://issues.apache.org/jira/browse/KNOX-2226?focusedWorklogId=392605&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392605
]
ASF GitHub Bot logged work on KNOX-2226:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/20 14:53
Start Date: 25/Feb/20 14:53
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #263: KNOX-2226 -
Add home page to Knox
URL: https://github.com/apache/knox/pull/263#discussion_r383927754
##########
File path:
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SSOCookieFederationFilter.java
##########
@@ -93,6 +95,13 @@ public void init( FilterConfig filterConfig ) throws
ServletException {
// gateway path for deriving an idp url when missing
gatewayPath = filterConfig.getInitParameter(GATEWAY_PATH);
+ if (StringUtils.isBlank(gatewayPath)) {
+ final GatewayConfig gatewayConfig = filterConfig.getServletContext() ==
null ? null
+ : (GatewayConfig)
filterConfig.getServletContext().getAttribute(GatewayConfig.GATEWAY_CONFIG_ATTRIBUTE);
+ if (gatewayConfig != null) {
+ gatewayPath = gatewayConfig.getGatewayPath();
+ }
+ }
Review comment:
> This should be its own method
+1 (let me wait a bit until for review comments before submitting a new
patchset)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 392605)
Time Spent: 6h 50m (was: 6h 40m)
> Add home page to Knox
> ---------------------
>
> Key: KNOX-2226
> URL: https://issues.apache.org/jira/browse/KNOX-2226
> Project: Apache Knox
> Issue Type: New Feature
> Components: AdminUI
> Affects Versions: 1.3.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Labels: UI
> Fix For: 1.4.0
>
> Attachments: OnePager-Apache_Knox_Home_Page.pdf
>
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> The lack of a home or landing page for Knox leaves users without a well-known
> place to discover the URLs for the various UIs and APIs that are being
> exposed for access by the gateway.
> This results in the need for QuickLinks in management applications like
> Ambari and Cloudera Manager to be rewritten to express the proxied URLs. This
> also results in the need for users to have to continue to go to these
> management applications for end-user URLs which is often not even appropriate.
> This proposal is for adding a Home page to Apache Knox which will present the
> various URLs in ways that are intuitive for being able to consume the proxied
> resources.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
