[
https://issues.apache.org/jira/browse/KNOX-2286?focusedWorklogId=401580&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-401580
]
ASF GitHub Bot logged work on KNOX-2286:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/20 16:49
Start Date: 11/Mar/20 16:49
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #287: KNOX-2286
Cleaner log messages about monitoring topologies/providers/descriptors
URL: https://github.com/apache/knox/pull/287
## What changes were proposed in this pull request?
Clearly indicating in the logs when
- a monitor (topologies/providers/descriptors) is configured
- a monitor (topologies/providers/descriptors) is started
As part of this job, I refactored out the `SharedProviderConfigMonitor` and
`DescriptorsMonitor` classes from `DefaultTopologyService` into a new package
(`org.apache.knox.gateway.services.topology.monitor`).
## How was this patch tested?
Redeployed Knox with my changes and touched files in
`conf/shared-providers`, `conf/descriptors` and `conf/topologies` directories:
monitoring worked as expected.
Relevant logs:
```
2020-03-11 17:27:22,838 INFO knox.gateway
(DefaultTopologyService.java:init(643)) - Configured monitoring topologies in
directory: /Users/smolnar/test/knoxGateway/conf/topologies
2020-03-11 17:27:22,839 INFO knox.gateway
(DefaultTopologyService.java:init(648)) - Configured monitoring simple
descriptors in directory: /Users/smolnar/test/knoxGateway/conf/descriptors
2020-03-11 17:27:23,061 INFO knox.gateway
(DefaultTopologyService.java:init(653)) - Configured monitoring shared provider
configurations in directory:
/Users/smolnar/test/knoxGateway/conf/shared-providers
...
2020-03-11 17:27:31,951 INFO knox.gateway
(DefaultTopologyService.java:startMonitor(548)) - Started monitoring simple
descriptors
2020-03-11 17:27:31,951 INFO knox.gateway
(DefaultTopologyService.java:startMonitor(548)) - Started monitoring shared
provider configurations
2020-03-11 17:27:31,952 INFO knox.gateway
(DefaultTopologyService.java:startMonitor(548)) - Started monitoring topologies
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 401580)
Remaining Estimate: 0h
Time Spent: 10m
> Rephrase misleading logs about provider/descriptor/topology monitoring
> ----------------------------------------------------------------------
>
> Key: KNOX-2286
> URL: https://issues.apache.org/jira/browse/KNOX-2286
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.4.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Minor
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While I was working on KNOX-2284, I found that the current log messages are
> misleading. They claim that monitoring started for providers/descriptors, but
> this is not actually true. Monitoring was configured but started later.
> The aim of this Jira is to refine the logging of this matter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
