[
https://issues.apache.org/jira/browse/KNOX-2304?focusedWorklogId=418518&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-418518
]
ASF GitHub Bot logged work on KNOX-2304:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/20 13:28
Start Date: 08/Apr/20 13:28
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #307: KNOX-2304 - CM
discovery cluster config monitor needs to be aware of …
URL: https://github.com/apache/knox/pull/307#discussion_r405524259
##########
File path:
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/monitor/PollingConfigurationAnalyzer.java
##########
@@ -365,12 +375,32 @@ private DiscoveryApiClient getApiClient(final
ServiceDiscoveryConfig discoveryCo
clusterName,
lastTimestamp);
for (ApiEvent event : events) {
- restartEvents.add(new RestartEvent(event));
+ List<ApiEventAttribute> attributes = event.getAttributes();
+ Map<String,Object> map = getAttributeMap(attributes);
Review comment:
Why not loop through the ApiEventAttribute list directly? There doesn't seem
to be any value in converting to a Map. You break the map apart in the same way
you would have to interrogate the ApiEventAttribute anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 418518)
Time Spent: 20m (was: 10m)
> CM discovery - cluster config monitor needs to be aware of all relevant CM
> event types
> --------------------------------------------------------------------------------------
>
> Key: KNOX-2304
> URL: https://issues.apache.org/jira/browse/KNOX-2304
> Project: Apache Knox
> Issue Type: Bug
> Components: cm-discovery
> Affects Versions: 1.4.0
> Reporter: Philip Zampino
> Assignee: Philip Zampino
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The CM cluster config monitor currently only polls for restart events. There
> are other event types (e.g., start) that should trigger the configuration
> analysis and subsequently trigger re-discovery.
> Need to determine the full set of event types that apply, and update the
> polling query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
