[
https://issues.apache.org/jira/browse/KNOX-2304?focusedWorklogId=418571&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-418571
]
ASF GitHub Bot logged work on KNOX-2304:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/20 14:34
Start Date: 08/Apr/20 14:34
Worklog Time Spent: 10m
Work Description: lmccay commented on pull request #307: KNOX-2304 - CM
discovery cluster config monitor needs to be aware of …
URL: https://github.com/apache/knox/pull/307#discussion_r405572741
##########
File path:
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/monitor/PollingConfigurationAnalyzer.java
##########
@@ -365,12 +375,32 @@ private DiscoveryApiClient getApiClient(final
ServiceDiscoveryConfig discoveryCo
clusterName,
lastTimestamp);
for (ApiEvent event : events) {
- restartEvents.add(new RestartEvent(event));
+ List<ApiEventAttribute> attributes = event.getAttributes();
+ Map<String,Object> map = getAttributeMap(attributes);
Review comment:
That is what I had before and it is much more complicated as I wanted to
avoid creating a map. Note that we are checking two correlated attributes. The
command issued and its status. Since you don't know what order they are in you
have to squirrel them away then check whether you have both then add. If we end
up having to add more events that would be even messier to do. Now, we can get
the map upfront and do whatever processing of it afterward much more cleanly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 418571)
Time Spent: 0.5h (was: 20m)
> CM discovery - cluster config monitor needs to be aware of all relevant CM
> event types
> --------------------------------------------------------------------------------------
>
> Key: KNOX-2304
> URL: https://issues.apache.org/jira/browse/KNOX-2304
> Project: Apache Knox
> Issue Type: Bug
> Components: cm-discovery
> Affects Versions: 1.4.0
> Reporter: Philip Zampino
> Assignee: Philip Zampino
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The CM cluster config monitor currently only polls for restart events. There
> are other event types (e.g., start) that should trigger the configuration
> analysis and subsequently trigger re-discovery.
> Need to determine the full set of event types that apply, and update the
> polling query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
