[
https://issues.apache.org/jira/browse/KNOX-2395?focusedWorklogId=453621&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453621
]
ASF GitHub Bot logged work on KNOX-2395:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/20 19:34
Start Date: 01/Jul/20 19:34
Worklog Time Spent: 10m
Work Description: smolnar82 opened a new pull request #358:
URL: https://github.com/apache/knox/pull/358
THIS IS STILL IN WIP STAGE: I'm working on the unit tests (they have
purposely missed out from this commit) as well as adding logs.
I wanted to create this PR so that you guys can give me early feedback.
## What changes were proposed in this pull request?
From now on end-users can select different implementation for certain Knox
services (where there are more than one implementations) through a newly
introduced `gateway-site.xml` configuration called `gateway.services`.
The format of this configuration is: `service1:impl1[, services:impl2,...]`
`DefaultGatewayServices` and `CLIGatewayServices` have been modified to use
the new service factories.
## How was this patch tested?
Ran the `knoxcli` tool:
- created the master secret
- added/listed some aliases
Started the Knox Gateway:
- checked the home page
- logged into the Admin UI
- modified the 'sandbox' topology
- modified a service definition (one that was listed in `sandbox`,
confirmed that it got redeployed)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 453621)
Remaining Estimate: 0h
Time Spent: 10m
> Make Gateway Services Pluggable
> -------------------------------
>
> Key: KNOX-2395
> URL: https://issues.apache.org/jira/browse/KNOX-2395
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.4.0
> Reporter: Philip Zampino
> Assignee: Sandor Molnar
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> For at least some gateway services, it would be useful to provide the ability
> to choose an implementation without requiring a code change (as it is today).
> Either DefaultGatewayServices should reference gateway-site configuration for
> default implementation overrides, OR the default implementations of the
> affected services should do the same.
> Being able to effect behavior through config in this way will make Knox more
> pluggable, not merely extensible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
