[
https://issues.apache.org/jira/browse/KNOX-2395?focusedWorklogId=456257&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456257
]
ASF GitHub Bot logged work on KNOX-2395:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/20 17:36
Start Date: 08/Jul/20 17:36
Worklog Time Spent: 10m
Work Description: smolnar82 commented on a change in pull request #358:
URL: https://github.com/apache/knox/pull/358#discussion_r451715039
##########
File path: gateway-release/home/conf/gateway-site.xml
##########
@@ -18,6 +18,11 @@ limitations under the License.
-->
<configuration>
+ <property>
+ <name>gateway.services</name>
Review comment:
> I had envisioned the use of distinct properties, rather than a single
"list" property.
> Something more explicit, like:
>
`<property><name>gateway.service.alias</name><value>org.apache.knox.gateway.services.security.impl.RemoteAliasService</value></property>
<property><name>gateway.service.tokenstate</name><value>org.apache.knox.gateway.services.token.impl.JournalBasedTokenStateService</value></property>`
>
> I think explicit class name values will make it easier for developers to
create and deploy Knox customizations/extensions. Given this, I think a _list_
of such things could quickly become difficult to read.
Thanks, @pzampino for your review comment. It makes sense and I'm in favor
of your recommended approach with a small alteration: I'd build the property
names as `gateway.service.$SERVICE.$PARAM` where service references the service
name and param is an arbitrary parameter name that Knox can interpret later on.
In this round, I'd add `impl` only but in upcoming changes, there will be
others. For instance:
```
<property>
<name>gateway.service.tokenstate.impl</name>
<value>org.apache.knox.gateway.services.token.impl.ZookeeperTokenStateService</value>
</property>
<property>
<name>gateway.service.tokenstate.useLocalAliasService</name>
<value>false</value>
<description>Indicates whether ZookeeperTokenStateService should use a
local alias service when storing tokens or purely do the job in
Zookeeper</description>
</property>
Any objection?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 456257)
Time Spent: 40m (was: 0.5h)
> Make Gateway Services Pluggable
> -------------------------------
>
> Key: KNOX-2395
> URL: https://issues.apache.org/jira/browse/KNOX-2395
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.4.0
> Reporter: Philip Zampino
> Assignee: Sandor Molnar
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> For at least some gateway services, it would be useful to provide the ability
> to choose an implementation without requiring a code change (as it is today).
> Either DefaultGatewayServices should reference gateway-site configuration for
> default implementation overrides, OR the default implementations of the
> affected services should do the same.
> Being able to effect behavior through config in this way will make Knox more
> pluggable, not merely extensible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
