[
https://issues.apache.org/jira/browse/KNOX-2408?focusedWorklogId=476546&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476546
]
ASF GitHub Bot logged work on KNOX-2408:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/20 11:49
Start Date: 31/Aug/20 11:49
Worklog Time Spent: 10m
Work Description: smolnar82 commented on a change in pull request #371:
URL: https://github.com/apache/knox/pull/371#discussion_r480077126
##########
File path:
gateway-server/src/test/java/org/apache/knox/gateway/services/token/impl/AliasBasedTokenStateServiceTest.java
##########
@@ -195,7 +204,8 @@ public void testAddAndRemoveTokenIncludesCache() throws
Exception {
* Verify that the token state reaper includes token state which has not
been cached, so it's not left in the keystore
* forever.
*/
- @Test
+ @Ignore("I'm not sure if this is a valid use case since we have everything
in the cache when eviction takes place")
Review comment:
@pzampino As you can see I only ignored this test case for now because
I'm not sure if it makes sense going forward. Since the eviction thread checks
everything in the cache we may remove this test case. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 476546)
Time Spent: 20m (was: 10m)
> Improve AliasBasedTokenState service performance
> ------------------------------------------------
>
> Key: KNOX-2408
> URL: https://issues.apache.org/jira/browse/KNOX-2408
> Project: Apache Knox
> Issue Type: Task
> Components: Server
> Affects Versions: 1.4.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> While working on KNOX-2402 there were some performance issues related to
> {{AliasBasedTokenStateService}} which the new tool revealed during the test
> phase:
> {{AliasBasedTokenStateService}}:
> - {{updateExpiration()}} goes directly to alias service rather than updating
> it locally and let the background thread does its job
> - {{getTokens}} goes directly to alias service
> {{DefaultTokenStateService}}:
> - we should start using {{ConcurrentHashMap}} instead of {{HashMap}} for
> {{tokenExpirations}} and {{maxTokenLifetimes}} -> many of the synchronization
> blocks could be get rid of (CHM gives better performance anyway)
> - review {{getTokens()}} usage
> - eviction: needs to consider the case when Gateway was restarted -> nothing
> found in memory -> eviction is extremely slow
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
