[
https://issues.apache.org/jira/browse/KNOX-2408?focusedWorklogId=480369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-480369
]
ASF GitHub Bot logged work on KNOX-2408:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/20 18:55
Start Date: 08/Sep/20 18:55
Worklog Time Spent: 10m
Work Description: smolnar82 commented on a change in pull request #371:
URL: https://github.com/apache/knox/pull/371#discussion_r485130067
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
##########
@@ -344,36 +320,44 @@ protected void validateToken(final String tokenId) throws
IllegalArgumentExcepti
}
}
- protected String getTimestampDisplay(long timestamp) {
+ private String getTimestampDisplay(long timestamp) {
return Instant.ofEpochMilli(timestamp).toString();
}
/**
* Method that deletes expired tokens based on the token timestamp.
*/
protected void evictExpiredTokens() {
- Set<String> tokensToEvict = new HashSet<>();
-
- for (final String tokenId : getTokens()) {
- try {
- if (needsEviction(tokenId)) {
- log.evictToken(tokenId);
- tokensToEvict.add(tokenId); // Add the token to the set of tokens to
evict
+ if (readyForEviction()) {
+ final Set<String> tokensToEvict = new HashSet<>();
+
+ for (final String tokenId : getTokenIds()) {
+ try {
+ if (needsEviction(tokenId)) {
+ log.evictToken(tokenId);
+ tokensToEvict.add(tokenId); // Add the token to the set of tokens
to evict
+ }
+ } catch (final Exception e) {
+ log.failedExpiredTokenEviction(tokenId, e);
}
- } catch (final Exception e) {
- log.failedExpiredTokenEviction(tokenId, e);
}
- }
- if (!tokensToEvict.isEmpty()) {
- try {
- removeTokens(tokensToEvict);
- } catch (UnknownTokenException e) {
- log.failedExpiredTokenEviction(e);
+ if (!tokensToEvict.isEmpty()) {
+ try {
+ removeTokens(tokensToEvict);
+ } catch (UnknownTokenException e) {
+ log.failedExpiredTokenEviction(e);
+ }
}
+ } else {
+ log.skipEviction();
}
}
+ protected boolean readyForEviction() {
+ return true;
Review comment:
It's overridden in `AliasBasedTokenStateService` where the returned
value depends on the state of loading all aliases from
`__gateway-credentials.jckes`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 480369)
Time Spent: 40m (was: 0.5h)
> Improve AliasBasedTokenState service performance
> ------------------------------------------------
>
> Key: KNOX-2408
> URL: https://issues.apache.org/jira/browse/KNOX-2408
> Project: Apache Knox
> Issue Type: Task
> Components: Server
> Affects Versions: 1.4.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.5.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> While working on KNOX-2402 there were some performance issues related to
> {{AliasBasedTokenStateService}} which the new tool revealed during the test
> phase:
> {{AliasBasedTokenStateService}}:
> - {{updateExpiration()}} goes directly to alias service rather than updating
> it locally and let the background thread does its job
> - {{getTokens}} goes directly to alias service
> {{DefaultTokenStateService}}:
> - we should start using {{ConcurrentHashMap}} instead of {{HashMap}} for
> {{tokenExpirations}} and {{maxTokenLifetimes}} -> many of the synchronization
> blocks could be get rid of (CHM gives better performance anyway)
> - review {{getTokens()}} usage
> - eviction: needs to consider the case when Gateway was restarted -> nothing
> found in memory -> eviction is extremely slow
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
