[
https://issues.apache.org/jira/browse/KNOX-2412?focusedWorklogId=479120&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-479120
]
ASF GitHub Bot logged work on KNOX-2412:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/20 14:02
Start Date: 04/Sep/20 14:02
Worklog Time Spent: 10m
Work Description: lmccay commented on a change in pull request #372:
URL: https://github.com/apache/knox/pull/372#discussion_r483635437
##########
File path:
gateway-service-knoxssout/src/main/java/org/apache/knox/gateway/service/knoxsso/WebSSOutResource.java
##########
@@ -44,7 +44,7 @@
private static final String SSO_COOKIE_NAME = "knoxsso.cookie.name";
private static final String DEFAULT_SSO_COOKIE_NAME = "hadoop-jwt";
- static final String RESOURCE_PATH = "/api/v1/webssout";
+ static final String RESOURCE_PATH = "knoxssout/api/v1/webssout";
Review comment:
Not all of the other APIs do that. It was done that way for APIs that
were initially intended to be deployed to a single dedicated topology. Like the
admin.xml.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 479120)
Time Spent: 50m (was: 40m)
> Add Logout Link to Home Page for Select Authentication Providers
> ----------------------------------------------------------------
>
> Key: KNOX-2412
> URL: https://issues.apache.org/jira/browse/KNOX-2412
> Project: Apache Knox
> Issue Type: Improvement
> Components: Homepage
> Reporter: Larry McCay
> Assignee: Larry McCay
> Priority: Major
> Fix For: 1.5.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> For some KnoxSSO providers/IDPs we can accomplish logout by just removing the
> KnoxSSO cookie. Now that we have a Home Page for Knox, we have somewhere to
> hang the logout link.
> This patch will add such a link as well as add KNOXSSOUT service to the
> relevant topology. Topology may be knoxsso or the homepage topology depending
> on CORS and the like.
> We do have the unauthenticated URLs feature in SSOCookieProvider in case we
> need it to get past the authentication provider of the hosting topology.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
