[
https://issues.apache.org/jira/browse/KNOX-2412?focusedWorklogId=479119&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-479119
]
ASF GitHub Bot logged work on KNOX-2412:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/20 14:02
Start Date: 04/Sep/20 14:02
Worklog Time Spent: 10m
Work Description: lmccay commented on a change in pull request #372:
URL: https://github.com/apache/knox/pull/372#discussion_r483634690
##########
File path:
knox-homepage-ui/home/app/sessionInformation/session.information.component.ts
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import {Component, OnInit} from '@angular/core';
+import {HomepageService} from '../homepage.service';
+import {SessionInformation} from './session.information';
+
+@Component({
+ selector: 'app-session-information',
+ templateUrl: './session.information.component.html',
+ providers: [HomepageService]
+})
+
+export class SessionInformationComponent implements OnInit {
+
+ sessionInformation: SessionInformation;
+ logoutSupported = true;
+
+ constructor(private homepageService: HomepageService) {
+ this['showSessionInformation'] = true;
+ }
+
+ getUser() {
+ if (this.sessionInformation) {
+ console.debug('SessionInformationComponent --> getUser() --> ' +
this.sessionInformation.user);
+ return this.sessionInformation.user;
+ }
+ console.debug('SessionInformationComponent --> getUser() --> dr.who');
+ return 'dr.who';
Review comment:
dr.who is common in Hadoop world. While I don't like it - it is better
than the UI saying "Welcome null". :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 479119)
Time Spent: 40m (was: 0.5h)
> Add Logout Link to Home Page for Select Authentication Providers
> ----------------------------------------------------------------
>
> Key: KNOX-2412
> URL: https://issues.apache.org/jira/browse/KNOX-2412
> Project: Apache Knox
> Issue Type: Improvement
> Components: Homepage
> Reporter: Larry McCay
> Assignee: Larry McCay
> Priority: Major
> Fix For: 1.5.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> For some KnoxSSO providers/IDPs we can accomplish logout by just removing the
> KnoxSSO cookie. Now that we have a Home Page for Knox, we have somewhere to
> hang the logout link.
> This patch will add such a link as well as add KNOXSSOUT service to the
> relevant topology. Topology may be knoxsso or the homepage topology depending
> on CORS and the like.
> We do have the unauthenticated URLs feature in SSOCookieProvider in case we
> need it to get past the authentication provider of the hosting topology.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
