pzampino commented on a change in pull request #469:
URL: https://github.com/apache/knox/pull/469#discussion_r670474747
##########
File path:
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/provider/HaServiceConfig.java
##########
@@ -57,4 +57,8 @@
boolean isNoFallbackEnabled();
void setNoFallbackEnabled(boolean noFallbackEnabled);
+
+ void setDisableStickySessionForUserAgents(String
disableStickySessionForUserAgents);
Review comment:
(minor) nit: The method name is misleading to me.
setStickySessionDisabledUserAgents() ?
##########
File path:
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/provider/impl/HaServiceConfigConstants.java
##########
@@ -53,4 +59,6 @@
boolean DEFAULT_NO_FALLBACK_ENABLED = false;
String DEFAULT_STICKY_SESSION_COOKIE_NAME = "KNOX_BACKEND";
+
+ String DEFAULT_DISABLE_LB_USER_AGENTS = "ClouderaODBCDriverforApacheHive";
Review comment:
What if the default includes multiple values in the future? Should this
be an array type instead?
##########
File path:
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/provider/HaServiceConfig.java
##########
@@ -57,4 +57,8 @@
boolean isNoFallbackEnabled();
void setNoFallbackEnabled(boolean noFallbackEnabled);
+
+ void setDisableStickySessionForUserAgents(String
disableStickySessionForUserAgents);
+
+ String getDisableStickySessionForUserAgents();
Review comment:
(minor) nit: The method name is misleading to me.
List<String> getStickySessionDisabledUserAgents() ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
