moresandeep commented on a change in pull request #469:
URL: https://github.com/apache/knox/pull/469#discussion_r670590337
##########
File path:
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/ConfigurableHADispatch.java
##########
@@ -89,6 +91,13 @@ public void init() {
if(stickySessionsEnabled) {
stickySessionCookieName = serviceConfig.getStickySessionCookieName();
}
+ /* if a configurable user agent list is defined to turn off Knox LB used
it */
+
if(!StringUtils.isBlank(serviceConfig.getDisableStickySessionForUserAgents())) {
+ /* configured user agents are comma separate list which *can* contain
whitespaces */
+ disableLoadBalancingForUserAgents =
Arrays.asList(serviceConfig.getDisableStickySessionForUserAgents()
Review comment:
Right, Phil mentioned the same, I'll change it.
##########
File path:
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/provider/HaServiceConfig.java
##########
@@ -57,4 +57,8 @@
boolean isNoFallbackEnabled();
void setNoFallbackEnabled(boolean noFallbackEnabled);
+
+ void setDisableStickySessionForUserAgents(String
disableStickySessionForUserAgents);
+
+ String getDisableStickySessionForUserAgents();
Review comment:
true, will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
