zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707432233
##########
File path:
gateway-provider-rewrite/src/test/java/org/apache/knox/gateway/filter/rewrite/api/UrlRewriteServletFilterTest.java
##########
@@ -527,41 +523,35 @@ public void
testRequestXmlBodyRewriteWithFilterInitParam() throws Exception {
@Test
public void
testRequestXmlBodyRewriteWithFilterInitParamForInvalidFilterConfig() throws
Exception {
- Enumeration<Appender> realAppenders =
NoOpAppender.setUpAndReturnOriginalAppenders();
- try {
-
- Map<String,String> initParams = new HashMap<>();
- initParams.put( "request.body", "test-filter-3" );
- testSetUp( initParams );
-
- String input = "<root
url='http://mock-host:42/test-input-path-1'><url>http://mock-host:42/test-input-path-2</url></root>";
- String expect = "<root
url='http://mock-host:42/test-input-path-2'><url>http://mock-host:42/test-input-path-2</url></root>";
-
- // Setup the server side request/response interaction.
- interaction.expect()
- .method( "PUT" )
- .requestUrl( "http://mock-host:42/test-output-path-1"; )
- .contentType( "text/xml" )
- .characterEncoding( StandardCharsets.UTF_8.name() )
- .content( expect, StandardCharsets.UTF_8 );
- interaction.respond()
- .status( 200 );
- interactions.add( interaction );
- request.setMethod( "PUT" );
- request.setURI( "/test-input-path" );
- //request.setVersion( "HTTP/1.1" );
- request.setHeader( "Host", "mock-host:42" );
- request.setHeader( "Content-Type", "text/xml; charset=UTF-8" );
- request.setContent( input );
-
- // Execute the request.
- response = TestUtils.execute( server, request );
-
- // Test the results.
- assertThat( response.getStatus(), is( 500 ) );
- } finally {
- NoOpAppender.resetOriginalAppenders( realAppenders );
- }
+ Map<String,String> initParams = new HashMap<>();
Review comment:
I'm not quite sure what was the purpose of the NoOpAppender. It just
temporary disabled logging while the test was running. The test doesn't check
any log related things. The class was added in 2013 but the commit message
doesn't contain any Jira reference so I couldn't get any info on the intent.
I'll try find out out why it was added but so far it looks like it doesn't
influence the test run.
cc: @kminder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
