zeroflag commented on pull request #488: URL: https://github.com/apache/knox/pull/488#issuecomment-919832184
> * This looks like it completely removes slf4j - is that correct? would it make sense to have the slf4j->log4j2 bridge added for any dependency that might use slf4j for logging? @risdenk Thanks for going through this big patch. At a few places in the Knox code we used `org.slf4j.LoggerFactory` and `org.slf4j.Logger` directly. I replaced these with Log4j2 and removed the slf4j dependency to make sure we won't use these again. If there is a third party dependency that uses slf4j for logging, that still should work since we have `log4j-slf4j-impl-2.14.0.jar` on the class path. ``` $ ls -al dep/ | grep log4j -rw-r--r-- 1 amagyar staff 301418 Jan 22 2020 log4j-api-2.14.0.jar -rw-r--r-- 1 amagyar staff 1762731 Jan 22 2020 log4j-core-2.14.0.jar -rw-r--r-- 1 amagyar staff 23871 Jan 22 2020 log4j-slf4j-impl-2.14.0.jar ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
