[
https://issues.apache.org/jira/browse/KNOX-2732?focusedWorklogId=759222&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759222
]
ASF GitHub Bot logged work on KNOX-2732:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 13:22
Start Date: 20/Apr/22 13:22
Worklog Time Spent: 10m
Work Description: zeroflag commented on code in PR #560:
URL: https://github.com/apache/knox/pull/560#discussion_r854126678
##########
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAuthCodeAssertionFilter.java:
##########
@@ -55,6 +57,10 @@ public void init( FilterConfig filterConfig ) throws
ServletException {
GatewayServices services = (GatewayServices)
filterConfig.getServletContext().getAttribute(GatewayServices.GATEWAY_SERVICES_ATTRIBUTE);
authority = services.getService(ServiceType.TOKEN_SERVICE);
sr = services.getService(ServiceType.SERVICE_REGISTRY_SERVICE);
+
+ this.tokenIssuer =
filterConfig.getInitParameter(JWTAccessTokenAssertionFilter.ISSUER) != null
+ ?
filterConfig.getInitParameter(JWTAccessTokenAssertionFilter.ISSUER)
Review Comment:
I don't know how likely this is, but the doc says it's a StringOrURI not an
array. If we ever need to support multiple issuers we can still use coma
separated values I guess, or introduce new application specific claim which is
an array.
Issue Time Tracking
-------------------
Worklog Id: (was: 759222)
Time Spent: 40m (was: 0.5h)
> Issuer claim in Knox JWTs should be configurable
> ------------------------------------------------
>
> Key: KNOX-2732
> URL: https://issues.apache.org/jira/browse/KNOX-2732
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.6.0
> Reporter: Philip Zampino
> Assignee: Attila Magyar
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, the issuer claim in JWTs issued by Knox is always "KNOXSSO". This
> value should be configurable via a KNOXTOKEN service param in the topology.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
