[
https://issues.apache.org/jira/browse/KNOX-2732?focusedWorklogId=759240&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759240
]
ASF GitHub Bot logged work on KNOX-2732:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 13:40
Start Date: 20/Apr/22 13:40
Worklog Time Spent: 10m
Work Description: moresandeep commented on code in PR #560:
URL: https://github.com/apache/knox/pull/560#discussion_r854149039
##########
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAccessTokenAssertionFilter.java:
##########
@@ -71,9 +72,9 @@ public void init( FilterConfig filterConfig ) throws
ServletException {
authority = services.getService(ServiceType.TOKEN_SERVICE);
sr = services.getService(ServiceType.SERVICE_REGISTRY_SERVICE);
- this.tokenIssuer =
filterConfig.getInitParameter(JWTAccessTokenAssertionFilter.ISSUER) != null
- ?
filterConfig.getInitParameter(JWTAccessTokenAssertionFilter.ISSUER)
- : JWTokenAttributes.DEFAULT_ISSUER;
+ this.tokenIssuer =
StringUtils.isEmpty(filterConfig.getInitParameter(JWTAccessTokenAssertionFilter.ISSUER))
Review Comment:
StringUtils.isBlank() is a little better since it checks for whitespace too.
##########
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAccessTokenAssertionFilter.java:
##########
@@ -71,9 +72,9 @@ public void init( FilterConfig filterConfig ) throws
ServletException {
authority = services.getService(ServiceType.TOKEN_SERVICE);
sr = services.getService(ServiceType.SERVICE_REGISTRY_SERVICE);
- this.tokenIssuer =
filterConfig.getInitParameter(JWTAccessTokenAssertionFilter.ISSUER) != null
- ?
filterConfig.getInitParameter(JWTAccessTokenAssertionFilter.ISSUER)
- : JWTokenAttributes.DEFAULT_ISSUER;
+ this.tokenIssuer =
StringUtils.isEmpty(filterConfig.getInitParameter(JWTAccessTokenAssertionFilter.ISSUER))
Review Comment:
[StringUtils.isBlank()](https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html#isBlank-java.lang.CharSequence-)
is a little better since it checks for whitespace too.
Issue Time Tracking
-------------------
Worklog Id: (was: 759240)
Time Spent: 1h (was: 50m)
> Issuer claim in Knox JWTs should be configurable
> ------------------------------------------------
>
> Key: KNOX-2732
> URL: https://issues.apache.org/jira/browse/KNOX-2732
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.6.0
> Reporter: Philip Zampino
> Assignee: Attila Magyar
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently, the issuer claim in JWTs issued by Knox is always "KNOXSSO". This
> value should be configurable via a KNOXTOKEN service param in the topology.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
