smolnar82 commented on code in PR #602:
URL: https://github.com/apache/knox/pull/602#discussion_r914826235
##########
gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/DefaultHttpClientFactory.java:
##########
@@ -128,12 +128,14 @@ public HttpClient createHttpClient(FilterConfig
filterConfig) {
if (doesRetryParamExist(filterConfig)) {
int retryCount =
Integer.parseInt(filterConfig.getInitParameter(PARAMETER_RETRY_COUNT));
+ LOG.setRetryCount(retryCount, serviceRole);
/* do we want to retry non-idempotent requests? default no */
boolean retryNonIdempotent = DEFAULT_PARAMETER_RETRY_NON_SAFE_REQUEST;
if (filterConfig.getInitParameter(PARAMETER_RETRY_NON_SAFE_REQUEST)
!= null) {
retryNonIdempotent = Boolean.parseBoolean(
filterConfig.getInitParameter(PARAMETER_RETRY_NON_SAFE_REQUEST));
+ LOG.setRetryNonIndependent(retryNonIdempotent, serviceRole);
Review Comment:
IMO, this should be outside of this `if` statement. Otherwise, we would
assume it's set to default because the log entry was not shown.
##########
gateway-spi/src/main/java/org/apache/knox/gateway/SpiGatewayMessages.java:
##########
@@ -91,10 +91,10 @@ public interface SpiGatewayMessages {
text = "The dispatch to {0} was disallowed because it fails the
dispatch whitelist validation. See documentation for dispatch whitelisting." )
void dispatchDisallowed(String uri);
- @Message( level = MessageLevel.DEBUG, text = "HTTP client connection timeout
is set to {0} for {1}" )
+ @Message( level = MessageLevel.INFO, text = "HTTP client connection timeout
is set to {0} msec for {1}" )
void setHttpClientConnectionTimeout(int connectionTimeout, String
serviceRole);
- @Message( level = MessageLevel.DEBUG, text = "HTTP client socket timeout is
set to {0} for {1}" )
+ @Message( level = MessageLevel.INFO, text = "HTTP client socket timeout is
set to {0} msec for {1}" )
Review Comment:
It should either be `ms` or `milliseconds`.
##########
gateway-spi/src/main/java/org/apache/knox/gateway/SpiGatewayMessages.java:
##########
@@ -91,10 +91,10 @@ public interface SpiGatewayMessages {
text = "The dispatch to {0} was disallowed because it fails the
dispatch whitelist validation. See documentation for dispatch whitelisting." )
void dispatchDisallowed(String uri);
- @Message( level = MessageLevel.DEBUG, text = "HTTP client connection timeout
is set to {0} for {1}" )
+ @Message( level = MessageLevel.INFO, text = "HTTP client connection timeout
is set to {0} msec for {1}" )
void setHttpClientConnectionTimeout(int connectionTimeout, String
serviceRole);
- @Message( level = MessageLevel.DEBUG, text = "HTTP client socket timeout is
set to {0} for {1}" )
+ @Message( level = MessageLevel.INFO, text = "HTTP client socket timeout is
set to {0} msec for {1}" )
void setHttpClientSocketTimeout(int csocketTimeout, String serviceRole);
Review Comment:
nit: typo in `csocketTimeout`: either `clientSocketTimeout` or
`socketTimeout` (I prefer the 2nd one).
##########
gateway-spi/src/main/java/org/apache/knox/gateway/SpiGatewayMessages.java:
##########
@@ -91,10 +91,10 @@ public interface SpiGatewayMessages {
text = "The dispatch to {0} was disallowed because it fails the
dispatch whitelist validation. See documentation for dispatch whitelisting." )
void dispatchDisallowed(String uri);
- @Message( level = MessageLevel.DEBUG, text = "HTTP client connection timeout
is set to {0} for {1}" )
+ @Message( level = MessageLevel.INFO, text = "HTTP client connection timeout
is set to {0} msec for {1}" )
Review Comment:
It should either be `ms` or `milliseconds`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
