MrtnBalazs commented on code in PR #602:
URL: https://github.com/apache/knox/pull/602#discussion_r914909700
##########
gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/DefaultHttpClientFactory.java:
##########
@@ -128,12 +128,14 @@ public HttpClient createHttpClient(FilterConfig
filterConfig) {
if (doesRetryParamExist(filterConfig)) {
int retryCount =
Integer.parseInt(filterConfig.getInitParameter(PARAMETER_RETRY_COUNT));
+ LOG.setRetryCount(retryCount, serviceRole);
/* do we want to retry non-idempotent requests? default no */
boolean retryNonIdempotent = DEFAULT_PARAMETER_RETRY_NON_SAFE_REQUEST;
if (filterConfig.getInitParameter(PARAMETER_RETRY_NON_SAFE_REQUEST)
!= null) {
retryNonIdempotent = Boolean.parseBoolean(
filterConfig.getInitParameter(PARAMETER_RETRY_NON_SAFE_REQUEST));
+ LOG.setRetryNonIndependent(retryNonIdempotent, serviceRole);
Review Comment:
Yes, that way the default value is logged as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
