smolnar82 commented on code in PR #605:
URL: https://github.com/apache/knox/pull/605#discussion_r925644227
##########
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java:
##########
@@ -592,6 +593,11 @@ public List<String> getExcludedSSLCiphers() {
return list;
}
+ @Override
+ public boolean getRenegotiation() {
Review Comment:
Please give a better name for this method. It does not reflect SSL.
Recommended: `isSSLRenegotiationAllowed`.
Thanks!
##########
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java:
##########
@@ -592,6 +593,11 @@ public List<String> getExcludedSSLCiphers() {
return list;
}
+ @Override
+ public boolean getRenegotiation() {
+ return Boolean.parseBoolean(get( SSL_RENEGOTIATION, "false" ));
Review Comment:
We already have a `getBoolean(String name, boolean default)` method. Please
use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
