smolnar82 commented on PR #605:
URL: https://github.com/apache/knox/pull/605#issuecomment-1191449534

   Thanks for the new patchset, @nanhuirong !
   I've just checked [Jetty's 
API](https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/util/ssl/SslContextFactory.html#isRenegotiationAllowed())
 and found that the default value is `true`:
   ```
   
[@ManagedAttribute](https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/util/annotation/ManagedAttribute.html)("Whether
 renegotiation is allowed") public boolean isRenegotiationAllowed()
   Returns:
   whether TLS renegotiation is allowed (true by default)
   ```
   Hence the question: why do we want to change the default to `false`?
   
   Cc. @lmccay 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to