[jira] [Work logged] (KNOX-2809) HDFSUI is not high available

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/KNOX-2809?focusedWorklogId=818339&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818339
 ]

ASF GitHub Bot logged work on KNOX-2809:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Oct/22 07:15
            Start Date: 19/Oct/22 07:15
    Worklog Time Spent: 10m 
      Work Description: smolnar82 commented on code in PR #638:
URL: https://github.com/apache/knox/pull/638#discussion_r999028813


##########
gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsUIHaDispatch.java:
##########
@@ -26,6 +30,26 @@ public HdfsUIHaDispatch() throws ServletException {
     super();
   }
 
+  @Override
+  public URI getDispatchUrl(final HttpServletRequest request) {
+    String decoded;
+
+    try {
+      decoded = URLDecoder.decode(request.getRequestURL().toString(), 
StandardCharsets.UTF_8.name() );
+    } catch (final Exception e) {
+      /* fall back in case of exception */
+      decoded = request.getRequestURL().toString();
+    }
+
+    final StringBuilder str = new StringBuilder(decoded);
+    final String query = request.getQueryString();
+    if ( query != null ) {
+      str.append('?');
+      str.append(query);
+    }
+    return URI.create(str.toString());
+  }
+

Review Comment:
   @Flamingo93 - the internal logic of this method is a copy-paste of 
`org.apache.knox.gateway.dispatch.URLDecodingDispatch.getDispatchUrl(HttpServletRequest)`.
 I'd recommend to refactor this out in a util class and make sure this class 
and `URLDecodingDispatch.getDispatchUrl(HttpServletRequest)` use the new util 
class method.
   We do not only avoid duplicated code, but the utility method can be unit 
tested.
   
   If I were you I'd create a new `URLUtil` class in `gateway-spi` in the 
`org.apache.knox.gateway.util` package.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 818339)
    Time Spent: 50m  (was: 40m)

> HDFSUI is not high available
> ----------------------------
>
>                 Key: KNOX-2809
>                 URL: https://issues.apache.org/jira/browse/KNOX-2809
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Chang Zhichao
>            Priority: Major
>             Fix For: 1.6.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> HDFSUI use org.apache.knox.gateway.dispatch.URLDecodingDispatch for request, 
> it didn't do failoverRequest when executeRequest failed.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)