[
https://issues.apache.org/jira/browse/KNOX-2809?focusedWorklogId=831661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831661
]
ASF GitHub Bot logged work on KNOX-2809:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/22 07:49
Start Date: 07/Dec/22 07:49
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #638:
URL: https://github.com/apache/knox/pull/638#discussion_r1041866727
##########
gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsUIHaDispatch.java:
##########
@@ -26,6 +30,26 @@ public HdfsUIHaDispatch() throws ServletException {
super();
}
+ @Override
+ public URI getDispatchUrl(final HttpServletRequest request) {
+ String decoded;
+
+ try {
+ decoded = URLDecoder.decode(request.getRequestURL().toString(),
StandardCharsets.UTF_8.name() );
+ } catch (final Exception e) {
+ /* fall back in case of exception */
+ decoded = request.getRequestURL().toString();
+ }
+
+ final StringBuilder str = new StringBuilder(decoded);
+ final String query = request.getQueryString();
+ if ( query != null ) {
+ str.append('?');
+ str.append(query);
+ }
+ return URI.create(str.toString());
+ }
+
Review Comment:
@Flamingo93 - any progress on this thread? Please address my above review
comment so that we can continue merging this PR. Thanks!
Issue Time Tracking
-------------------
Worklog Id: (was: 831661)
Time Spent: 1h (was: 50m)
> HDFSUI is not high available
> ----------------------------
>
> Key: KNOX-2809
> URL: https://issues.apache.org/jira/browse/KNOX-2809
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Chang Zhichao
> Priority: Major
> Fix For: 1.6.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> HDFSUI use org.apache.knox.gateway.dispatch.URLDecodingDispatch for request,
> it didn't do failoverRequest when executeRequest failed.
> Â
--
This message was sent by Atlassian Jira
(v8.20.10#820010)