smolnar82 commented on PR #672: URL: https://github.com/apache/knox/pull/672#issuecomment-1314920268
Thanks, @debiswal for addressing my direct review comments. There is one more I mentioned above: > Before we merge your changes, I'd like to ask you to write separate unit test classes for the newly introduced service model generators (there are plenty of samples under the src/test/java folder in the gateway-discovery-cm module. Without the new test classes, we cannot merge your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
