smolnar82 commented on PR #672: URL: https://github.com/apache/knox/pull/672#issuecomment-1316588587
Thanks, @debiswal for the unit test classes. I also see you changed the following too: - SSL_ENABLED is registered on the role level (before it was on the service level) in the returning `model` instance - HTTP and HTTPS ports are registered with their role types instead of their role names in the returning `model` instance Above, you claimed this was tested before you submitted this PR. So either it wasn't working that time or it's not working now. Could you please confirm that this very recent change is tested properly? Cc. @zeroflag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
