[
https://issues.apache.org/jira/browse/KNOX-2748?focusedWorklogId=840169&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-840169
]
ASF GitHub Bot logged work on KNOX-2748:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/23 07:51
Start Date: 19/Jan/23 07:51
Worklog Time Spent: 10m
Work Description: MrtnBalazs opened a new pull request, #716:
URL: https://github.com/apache/knox/pull/716
## What changes were proposed in this pull request?
Fixed the HashiCorpVaultAliasService `getPasswordFromAliasForCluster`
function, because it worked incorrectly when the generate flag was set to
`true`.
## How was this patch tested?
I extended the existing unit tests.
Issue Time Tracking
-------------------
Worklog Id: (was: 840169)
Remaining Estimate: 0h
Time Spent: 10m
> HashicorpVaultAliasService getPasswordFromAliasForCluster looks incorrecct
> --------------------------------------------------------------------------
>
> Key: KNOX-2748
> URL: https://issues.apache.org/jira/browse/KNOX-2748
> Project: Apache Knox
> Issue Type: Bug
> Reporter: Attila Magyar
> Assignee: Marton Balázs
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> @Override
> public char[] getPasswordFromAliasForCluster(String clusterName, String
> alias, boolean generate) throws AliasServiceException {
> if(generate) {
> getPasswordFromAliasForCluster(clusterName, alias);
> }
> return getPasswordFromAliasForCluster(clusterName, alias); // this is
> just the same method as above
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
