[
https://issues.apache.org/jira/browse/KNOX-2748?focusedWorklogId=840186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-840186
]
ASF GitHub Bot logged work on KNOX-2748:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/23 08:56
Start Date: 19/Jan/23 08:56
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #716:
URL: https://github.com/apache/knox/pull/716#discussion_r1080967212
##########
gateway-service-hashicorp-vault/src/test/java/org/apache/knox/gateway/backend/hashicorp/vault/TestHashicorpVaultAliasService.java:
##########
@@ -184,6 +185,9 @@ public void testVaultIntegration() throws Exception {
assertNull(aliasService.getPasswordFromAliasForCluster(clusterName,
alias));
assertEquals(0, aliasService.getAliasesForCluster(clusterName).size());
+ char[] generatedPassword =
aliasService.getPasswordFromAliasForCluster(clusterName, alias, true);
+ assertNotNull(generatedPassword != null);
+
Review Comment:
You may want to make sure the generated password for `alias` is not the same
as `aliasPassword`
Issue Time Tracking
-------------------
Worklog Id: (was: 840186)
Time Spent: 20m (was: 10m)
> HashicorpVaultAliasService getPasswordFromAliasForCluster looks incorrecct
> --------------------------------------------------------------------------
>
> Key: KNOX-2748
> URL: https://issues.apache.org/jira/browse/KNOX-2748
> Project: Apache Knox
> Issue Type: Bug
> Reporter: Attila Magyar
> Assignee: Marton Balázs
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code}
> @Override
> public char[] getPasswordFromAliasForCluster(String clusterName, String
> alias, boolean generate) throws AliasServiceException {
> if(generate) {
> getPasswordFromAliasForCluster(clusterName, alias);
> }
> return getPasswordFromAliasForCluster(clusterName, alias); // this is
> just the same method as above
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
