[
https://issues.apache.org/jira/browse/KNOX-2950?focusedWorklogId=882882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882882
]
ASF GitHub Bot logged work on KNOX-2950:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/23 11:49
Start Date: 02/Oct/23 11:49
Worklog Time Spent: 10m
Work Description: zeroflag commented on code in PR #787:
URL: https://github.com/apache/knox/pull/787#discussion_r1342588261
##########
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java:
##########
@@ -933,6 +936,20 @@ private synchronized void internalActivateArchive(
Topology topology, File warDi
}
}
+ private void processApplicationPathAliases(File warDir, Topology topology) {
+ final Map<String, Collection<String>> applicationPathAliases =
config.getApplicationPathAliases();
+ if (!applicationPathAliases.isEmpty()) {
Review Comment:
Then at least let's make it a null check instead of `isEmpty`. That would
protect us against NPEs, while this doesn't defend against anything.
Personally if `config.getApplicationPathAliases()` is guaranteed to be not
null, I wouldn't even use a null check, but if I had to decide between those 2
then I would choose a null check.
Issue Time Tracking
-------------------
Worklog Id: (was: 882882)
Time Spent: 50m (was: 40m)
> Token generation should be reachable using the old URL
> ------------------------------------------------------
>
> Key: KNOX-2950
> URL: https://issues.apache.org/jira/browse/KNOX-2950
> Project: Apache Knox
> Issue Type: Bug
> Components: TokenGenerationUI
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> With KNOX-2811, the token generation UI's URL is changed from
> {{'.../tokengen/index.html'}} to {{'.../token-generation/index.html'}}. The
> idea was that clients will use the Knox Home page to go to that particular
> UI. However, it might be the case that other 3rd party tools have that link
> hard-coded.
> So it'd be nice to reach the same UI with an additional context with the old
> name ({{tokengen}}).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
