[
https://issues.apache.org/jira/browse/KNOX-2950?focusedWorklogId=883634&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883634
]
ASF GitHub Bot logged work on KNOX-2950:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/23 07:29
Start Date: 06/Oct/23 07:29
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #787:
URL: https://github.com/apache/knox/pull/787#discussion_r1348347251
##########
knox-token-management-ui/token-management/app/token.management.component.ts:
##########
@@ -30,7 +30,9 @@ import {MatSort} from '@angular/material/sort';
export class TokenManagementComponent implements OnInit {
- tokenGenerationPageURL = window.location.pathname.replace(new
RegExp('token-management/.*'), 'token-generation/index.html');
+ pathParts = window.location.pathname.split('/');
Review Comment:
I couldn't agree more, but I did not find out (yet) how to do that properly
in TypeScript between different Maven modules. Let's leave it as-is for now and
refactor this out when I'll have time to investigate.
Issue Time Tracking
-------------------
Worklog Id: (was: 883634)
Time Spent: 1h 20m (was: 1h 10m)
> Token generation should be reachable using the old URL
> ------------------------------------------------------
>
> Key: KNOX-2950
> URL: https://issues.apache.org/jira/browse/KNOX-2950
> Project: Apache Knox
> Issue Type: Bug
> Components: TokenGenerationUI
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> With KNOX-2811, the token generation UI's URL is changed from
> {{'.../tokengen/index.html'}} to {{'.../token-generation/index.html'}}. The
> idea was that clients will use the Knox Home page to go to that particular
> UI. However, it might be the case that other 3rd party tools have that link
> hard-coded.
> So it'd be nice to reach the same UI with an additional context with the old
> name ({{tokengen}}).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
