pzampino commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1626496448
##########
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##########
@@ -277,4 +278,34 @@ public Enumeration<String> getInitParameterNames() {
return config.getInitParameterNames();
}
}
+
+ private Exception sanitizeException(Exception e) {
+ if (e == null || e.getMessage() == null) {
+ return e;
+ }
+ if (!isErrorMessageSanitizationEnabled || e.getMessage() == null) {
+ return e;
+ }
+ String sanitizedMessage =
e.getMessage().replaceAll("\\b(?:\\d{1,3}\\.){3}\\d{1,3}\\b", "[hidden]");
+ return createNewException(e, sanitizedMessage);
+ }
+
+ private <T extends Exception> T createNewException(T e, String
sanitizedMessage) {
+ try {
+ Constructor<? extends Exception> constructor =
e.getClass().getConstructor(String.class, Throwable.class);
+ T sanitizedException = (T) constructor.newInstance(sanitizedMessage,
e.getCause());
+ sanitizedException.setStackTrace(e.getStackTrace());
+ return sanitizedException;
+ } catch (Exception ex) {
+ Exception genericException = new Exception(sanitizedMessage,
e.getCause());
+ genericException.setStackTrace(e.getStackTrace());
+ return (T) genericException;
+ }
+ }
+
+ private <T extends Exception> T sanitizeAndRethrow(Exception e) throws T {
+ Exception sanitizedException = sanitizeException(e);
+ LOG.failedToExecuteFilter(sanitizedException);
+ throw (T) sanitizedException;
Review Comment:
It seems to me that all the callers of this method invoke it as `throw
sanitizeAndRethrow(e) ` ; If this method **return**ed the new exception object,
it would be thrown by those invocations, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
