lmccay commented on PR #1033: URL: https://github.com/apache/knox/pull/1033#issuecomment-2863267406
> KNOX-3138 implemented try-with-resources for Closeables (prevents resource leaks) Closeables need to be closed properly and the native way is try-with-resources. I haven't executed any tests for one simple reason: if the changed code is buildable, I don't expect any issues (It's not the first time when I implement try-with-resources) As you can see, all checks are green. > > I wish I could provide more details. @dk2k - I'd like to better understand your motivation for making this change. Did you encounter an issue with them not being closed? If so, have to tried this and observed it being addressed? Otherwise, I'd like to understand how you determined that you wanted to make this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
