dk2k commented on PR #1033: URL: https://github.com/apache/knox/pull/1033#issuecomment-2863550081
@lmccay try-with-resources (TwR) was introduced exactly for these cases. If a closeable has a non-empty close() method, it should be called. Of course, you can call close() explicitly, but it's boilerplate code. I found this issue with static analysis tool. From my experience: if code is buildable after such changes, it means the changes are safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
