[
https://issues.apache.org/jira/browse/KNOX-3214?focusedWorklogId=994601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-994601
]
ASF GitHub Bot logged work on KNOX-3214:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/25 16:29
Start Date: 03/Dec/25 16:29
Worklog Time Spent: 10m
Work Description: moresandeep commented on PR #1116:
URL: https://github.com/apache/knox/pull/1116#issuecomment-3607721799
> * elated tests
Great question, I can tell you putting all tests in one file would be a
nightmare! what we can do is we can either
1. Group the tests in one single file (multiple tests per file)
2. Group tests in sub-folders (sub folder needs to have `__init__.py` file
(it can be empty))
> Is there a way to disable these tests on specific PRs that don't need them
to run?
Good idea, i updated the logic to skip tests based on label `skip-tests` but
this skips all the tests. I don't currently have a way to skip a specific test
though. I am open to suggestions though.
> Why are there two docker files? Does the local have to be included in the
repo?
I am assuming you are referring to `Dockerfile` and `Dockerfile.local`
`Dockerfile` is used by workflow, `Dockerfile.local` is used to create knox
image on any dockerized environment. The reason for including this is, firstly
it helps in local testing and secondly, in case we move to other env (i.e. non
github workflow env) we can port this code easily.
Hopefully this helps.
Issue Time Tracking
-------------------
Worklog Id: (was: 994601)
Time Spent: 1h 50m (was: 1h 40m)
> Add docker based integration tests
> ----------------------------------
>
> Key: KNOX-3214
> URL: https://issues.apache.org/jira/browse/KNOX-3214
> Project: Apache Knox
> Issue Type: Bug
> Components: CI
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Add support for docker based integration tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
