[ 
https://issues.apache.org/jira/browse/KNOX-3214?focusedWorklogId=994650&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-994650
 ]

ASF GitHub Bot logged work on KNOX-3214:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Dec/25 18:55
            Start Date: 03/Dec/25 18:55
    Worklog Time Spent: 10m 
      Work Description: smolnar82 commented on code in PR #1116:
URL: https://github.com/apache/knox/pull/1116#discussion_r2586256065


##########
.github/workflows/compose/docker-compose.yml:
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with this
+# work for additional information regarding copyright ownership. The ASF
+# licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+# <p>
+# http://www.apache.org/licenses/LICENSE-2.0
+# <p>
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+version: '3'
+
+services:
+  knox-dev:
+    build:
+      context: ../build
+      dockerfile: Dockerfile
+    image: moresandeep/knox-dev:master
+
+  knox-dev-local:
+    build:
+      context: ../build
+      dockerfile: Dockerfile.local
+      args:
+        knoxurl: ${knoxurl:-https://github.com/apache/knox.git}
+        branch: ${branch:-master}
+    image: moresandeep/knox-dev:local
+
+  ldap:
+    image: moresandeep/knox-dev:master

Review Comment:
   Does `moresandeep` needs to be hard-coded here?



##########
.github/workflows/compose/docker-compose.yml:
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with this
+# work for additional information regarding copyright ownership. The ASF
+# licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+# <p>
+# http://www.apache.org/licenses/LICENSE-2.0
+# <p>
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+version: '3'
+
+services:
+  knox-dev:
+    build:
+      context: ../build
+      dockerfile: Dockerfile
+    image: moresandeep/knox-dev:master
+
+  knox-dev-local:
+    build:
+      context: ../build
+      dockerfile: Dockerfile.local
+      args:
+        knoxurl: ${knoxurl:-https://github.com/apache/knox.git}
+        branch: ${branch:-master}
+    image: moresandeep/knox-dev:local
+
+  ldap:
+    image: moresandeep/knox-dev:master
+    command: /ldap.sh
+
+  knox:
+    image: moresandeep/knox-dev:master

Review Comment:
   Does `moresandeep` needs to be hard-coded here?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 994650)
    Time Spent: 2h 20m  (was: 2h 10m)

> Add docker based integration tests
> ----------------------------------
>
>                 Key: KNOX-3214
>                 URL: https://issues.apache.org/jira/browse/KNOX-3214
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: CI
>            Reporter: Sandeep More
>            Assignee: Sandeep More
>            Priority: Major
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Add support for docker based integration tests.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to