[
https://issues.apache.org/jira/browse/KNOX-3277?focusedWorklogId=1010129&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1010129
]
ASF GitHub Bot logged work on KNOX-3277:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/26 16:50
Start Date: 18/Mar/26 16:50
Worklog Time Spent: 10m
Work Description: handavid commented on code in PR #1177:
URL: https://github.com/apache/knox/pull/1177#discussion_r2954853708
##########
gateway-server/src/main/java/org/apache/knox/gateway/services/ldap/backend/LdapProxyBackend.java:
##########
@@ -445,7 +459,11 @@ private void copyAttribute(Entry source, Entry target,
String attributeName) thr
if (attr != null) {
// Copy all values of the attribute (important for multi-valued
attributes like objectClass)
for (org.apache.directory.api.ldap.model.entry.Value value : attr)
{
- target.add(attributeName, value.getString());
+ try {
+ target.add(attributeName, value.getString());
+ } catch (Exception e) {
+ LOG.ldapAttributeCopyError(e);
Review Comment:
right. I was conflicted about this behavior also. The problem I was
originally solving was that the entry is omitted from search results if we
request an attribute that isn't defined in the proxy schema. Let me re-check
this behavior now that I've fixed the proxy schema to include both `memberOf`
and `sAMAccountName`.
Issue Time Tracking
-------------------
Worklog Id: (was: 1010129)
Time Spent: 50m (was: 40m)
> Improve LDAP pluggable backend to work with AD
> ----------------------------------------------
>
> Key: KNOX-3277
> URL: https://issues.apache.org/jira/browse/KNOX-3277
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Reporter: David Han
> Assignee: David Han
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Knox exposed an LDAP interface in KNOX-3247.
> The code needs to be tested against and improved to work with AD.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
