[
https://issues.apache.org/jira/browse/KNOX-3277?focusedWorklogId=1010131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1010131
]
ASF GitHub Bot logged work on KNOX-3277:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/26 17:02
Start Date: 18/Mar/26 17:02
Worklog Time Spent: 10m
Work Description: handavid commented on code in PR #1177:
URL: https://github.com/apache/knox/pull/1177#discussion_r2954864171
##########
gateway-server/src/main/java/org/apache/knox/gateway/services/ldap/GroupLookupInterceptor.java:
##########
@@ -44,6 +44,7 @@ public class GroupLookupInterceptor extends BaseInterceptor {
private LdapBackend backend;
private static final Pattern UID_PATTERN =
Pattern.compile(".*\\(uid=([^)]+)\\).*");
private static final Pattern CN_PATTERN =
Pattern.compile(".*\\(cn=([^)]+)\\).*");
+ private static final Pattern SAMAACCOUNTNAME_PATTERN =
Pattern.compile(".*\\(sAMAccountName=([^)]+)\\).*");
Review Comment:
There's a name normalizing filter somewhere in the interceptor chain prior
to this point. The filter will have the normalized `sAMAccountName` string.
Issue Time Tracking
-------------------
Worklog Id: (was: 1010131)
Time Spent: 1h (was: 50m)
> Improve LDAP pluggable backend to work with AD
> ----------------------------------------------
>
> Key: KNOX-3277
> URL: https://issues.apache.org/jira/browse/KNOX-3277
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Reporter: David Han
> Assignee: David Han
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Knox exposed an LDAP interface in KNOX-3247.
> The code needs to be tested against and improved to work with AD.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
